Skip to content

Northwest|May-2025 |Sofayas Solomon|Sprint-1 #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Northwest|May-2025 |Sofayas Solomon|Sprint-1 #624

wants to merge 3 commits into from

Conversation

sofayas
Copy link

@sofayas sofayas commented Jun 29, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this tas

Changelist

This PR completes all assigned exercises and fixes in Sprint 1 of the Module-Structuring-and-Testing-Data coursework. Changes were made across key exercises, mandatory error corrections, and interpretation explanations. All code was tested and reviewed before committing.

✅ Key Changes:

  • Completed all tasks in Sprint-1/1-key-exercises/ (e.g. initials, random, paths, count)
  • Fixed syntax and logic errors in files under 2-mandatory-errors/
  • Answered all interpretation questions in 3-mandatory-interpret/ with full step-by-step breakdowns
  • Added supporting files for exercises like cardNumber.js, percentage-change.js, timeFormat.js, and more
  • Used proper string and number conversion methods (slice, substring, Number, etc.)
  • Followed best practices for formatting, naming, and commenting

🔍 Other Notes:

  • Code has been formatted with Prettier
  • All files were tested using node to ensure no syntax errors
  • Branch: coursework/sprint-1-

Questions

  1. Could you please review my explanation comments in the interpretation tasks? I want to make sure I'm understanding the logic clearly.
  2. Is my code formatting and variable naming consistent with good JavaScript practice?
  3. I tested everything with node, but I’m not sure if I missed any edge cases — is there anything you'd suggest testing differently?
  4. Are there any ways I can improve the readability or clarity of my answers?

@sofayas sofayas added the Needs Review Participant to add when requesting review label Jun 29, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 6, 2025 •
edited
Loading

Can you edit the PR title so that it matches the format described in the Self-checklist?
image

cjyuan
cjyuan reviewed Jul 6, 2025
View reviewed changes
Sprint-1/1-key-exercises/3-paths.js
const dir = filePath.slice(0, lastSlashIndex); // This gives us everything up to (but not including) the last /
const ext = base.slice(dotIndex); // gives ".txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is dotIndex ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Cj, i tried to explain it in the commit and hope i explained it better

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 6, 2025
@sofayas sofayas changed the title Complete sprint 1 exercises and fix errors in interpretation tasks Northwest|May-2025 |Sofayas Solomon|coursework/sprint-1 Jul 9, 2025
@sofayas sofayas changed the title Northwest|May-2025 |Sofayas Solomon|coursework/sprint-1 Northwest|May-2025 |Sofayas Solomon|sprint-1 Jul 9, 2025
@sofayas sofayas changed the title Northwest|May-2025 |Sofayas Solomon|sprint-1 Northwest|May-2025 |Sofayas Solomon|Sprint-1 Jul 9, 2025
@sofayas sofayas added the Needs Review Participant to add when requesting review label Jul 9, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 9, 2025

Did you forgot to push your changes to GitHub? I don't see any new commits on this branch.

Could you also practice responding to comments directly in the comment threads? It could make tracking the discussion easier.
image

Here is a simplified version of best practices ChatGPT suggested for responding to inline comments in a pull request:

  • ✅ Reply to every comment – Let the reviewer know you saw it.
  • ✏️ Make the change if needed – Fix the code if the comment points out a real issue.
  • 🤔 Explain if you don't agree – If you think the code is fine, politely explain why.
  • ✅ Mark as resolved when done – Only mark comments resolved after you fix or respond.
  • 💬 Keep replies short and polite – Be respectful and to the point.
  • ⏱️ Respond soon – Don’t wait too long to reply.
  • 🧪 Test your changes – Make sure your fixes actually work.
  • 📍 Reply directly under the comment – This keeps the conversation easy to follow.

@cjyuan cjyuan removed the Needs Review Participant to add when requesting review label Jul 9, 2025
@sofayas
Copy link
Author

sofayas commented Jul 10, 2025

Did you forgot to push your changes to GitHub? I don't see any new commits on this branch.

Could you also practice responding to comments directly in the comment threads? It could make tracking the discussion easier. image

Here is a simplified version of best practices ChatGPT suggested for responding to inline comments in a pull request:

  • ✅ Reply to every comment – Let the reviewer know you saw it.
  • ✏️ Make the change if needed – Fix the code if the comment points out a real issue.
  • 🤔 Explain if you don't agree – If you think the code is fine, politely explain why.
  • ✅ Mark as resolved when done – Only mark comments resolved after you fix or respond.
  • 💬 Keep replies short and polite – Be respectful and to the point.
  • ⏱️ Respond soon – Don’t wait too long to reply.
  • 🧪 Test your changes – Make sure your fixes actually work.
  • 📍 Reply directly under the comment – This keeps the conversation easy to follow.

Dear Cj, yes i forgot to push my commit. but i am trying to improve my mistakes, i tend to lose focus sometimes for some reason

@sofayas sofayas added the Needs Review Participant to add when requesting review label Jul 10, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 10, 2025

Thanks for your prompt and clear responses in the comment threads.

Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 10, 2025
@sofayas
Copy link
Author

sofayas commented Jul 11, 2025

Thanks for your prompt and clear responses in the comment threads.

Well done!

Dear Cj, Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofayas @cjyuan